Change in docker-playground[master]: ttcn3-*-test: don't hardcode /usr/local/bin/

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Jan 28 13:04:47 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/12694 )

Change subject: ttcn3-*-test: don't hardcode /usr/local/bin/
......................................................................


Patch Set 3:

(2 comments)

New simple and clean patch that just removes /usr/local/bin.

https://gerrit.osmocom.org/#/c/12694/2/ttcn3-bts-test/jenkins.sh
File ttcn3-bts-test/jenkins.sh:

https://gerrit.osmocom.org/#/c/12694/2/ttcn3-bts-test/jenkins.sh@a37
PS2, Line 37: 
> whay are we removing the config file argument, if this commit is fixing the /usr/local/bin path?!?
I had assumed that it would be cleaner to remove the entire run command here, and use the default run command specified in Dockerfile instead.

That's why I had deleted the whole line (including the config parameter).

But I've realized that the cleanest way to do this is just remove /usr/local/bin from each command in jenkins.sh and modify nothing else. So I've pushed a new patch version, please take another look.


https://gerrit.osmocom.org/#/c/12694/3/ttcn3-sip-test/jenkins.sh
File ttcn3-sip-test/jenkins.sh:

https://gerrit.osmocom.org/#/c/12694/3/ttcn3-sip-test/jenkins.sh@30
PS3, Line 30: -M /data/unix/mncc
Vadim noted that -M is invalid for osmo-sip-connector in a related patch, so I've fixed it here:
https://gerrit.osmocom.org/#/c/docker-playground/+/12707/



-- 
To view, visit https://gerrit.osmocom.org/12694
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d1427e66028ffd15fed211b2dab5adc37718666
Gerrit-Change-Number: 12694
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 28 Jan 2019 13:04:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190128/2e127723/attachment.htm>


More information about the gerrit-log mailing list