Change in osmo-bts[master]: common/vty.c: fix 'cfg_phy_no_inst_cmd' command description

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Jan 27 13:42:13 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12702 )

Change subject: common/vty.c: fix 'cfg_phy_no_inst_cmd' command description
......................................................................

common/vty.c: fix 'cfg_phy_no_inst_cmd' command description

A comma is needed to separate a command definition from its
description, not the parts of description. Let's fix this.

Before this patch:

  OsmoBTS# configure terminal
  OsmoBTS(config)# phy 0
  OsmoBTS(phy)# no?

    no  PHY Instance number

  OsmoBTS(phy)# no ?

    instance
    osmotrx   OsmoTRX Transceiver configuration

After this patch:

  OsmoBTS# configure terminal
  OsmoBTS(config)# phy 0
  OsmoBTS(phy)# no?

    no  Negate a command or set its defaults

  OsmoBTS(phy)# no ?

    instance  Select a PHY instance to remove
    osmotrx   OsmoTRX Transceiver configuration

Change-Id: If10d85abc6506118ba08c37e8101f423d6f838ea
---
M src/common/vty.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/vty.c b/src/common/vty.c
index bb88c57..e4a9dc1 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -1463,8 +1463,8 @@
 }
 
 DEFUN(cfg_phy_no_inst, cfg_phy_no_inst_cmd,
-	"no instance <0-255>"
-	NO_STR "Select a PHY instance to remove\n", "PHY Instance number\n")
+	"no instance <0-255>",
+	NO_STR "Select a PHY instance to remove\n" "PHY Instance number\n")
 {
 	int inst_nr = atoi(argv[0]);
 	struct phy_link *plink = vty->index;

-- 
To view, visit https://gerrit.osmocom.org/12702
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If10d85abc6506118ba08c37e8101f423d6f838ea
Gerrit-Change-Number: 12702
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190127/9da82534/attachment.htm>


More information about the gerrit-log mailing list