Change in osmo-msc[master]: Handle LCLS-NOTIFICATION message from BSS

[Max]

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12608 )

Change subject: Handle LCLS-NOTIFICATION message from BSS
......................................................................

Handle LCLS-NOTIFICATION message from BSS

Change-Id: Ibf5f9cad1f70aee56d5bca8fe09a24ca417e7a63
Related: OS#2487
---
M src/libmsc/a_iface_bssap.c
1 file changed, 25 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c
index 41af93c..cb245b8 100644
--- a/src/libmsc/a_iface_bssap.c
+++ b/src/libmsc/a_iface_bssap.c
@@ -585,6 +585,29 @@
 	return 0;
 }
 
+/* Handle incoming LCLS-NOTIFICATION BSSMAP message: 3GPP TS 48.008 §3.2.1.93 */
+static int bssmap_rx_lcls_notif(const struct ran_conn *conn, const struct msgb *msg, const struct tlv_parsed *tp)
+{
+
+	bool status_avail = TLVP_PRESENT(tp, GSM0808_IE_LCLS_BSS_STATUS),
+	      break_avail = TLVP_PRESENT(tp, GSM0808_IE_LCLS_BREAK_REQ);
+
+	/* Either §3.2.2.119 LCLS-BSS-Status or §3.2.2.120 LCLS-Break-Request shall be present */
+	if (!(status_avail ^ break_avail)) {
+		LOGPCONN(conn, LOGL_ERROR, "Ignoring broken LCLS Notification message\n");
+		return -EINVAL;
+	}
+
+	if (status_avail)
+		LOGPCONN(conn, LOGL_NOTICE, "Received LCLS Status: %s\n",
+			 gsm0808_lcls_status_name(tlvp_val8(tp, GSM0808_IE_LCLS_BSS_STATUS, GSM0808_LCLS_STS_NA)));
+
+	if (break_avail)
+		LOGPCONN(conn, LOGL_NOTICE, "Received LCLS Break Request\n");
+
+	return 0;
+}
+
 /* Handle incoming connection oriented BSSMAP messages */
 static int rx_bssmap(struct osmo_sccp_user *scu, const struct a_conn_info *a_conn_info, struct msgb *msg)
 {
@@ -646,6 +669,8 @@
 		return bssmap_rx_sapi_n_rej(conn, msg, &tp);
 	case BSS_MAP_MSG_ASSIGMENT_COMPLETE:
 		return bssmap_rx_ass_compl(conn, msg, &tp);
+	case BSS_MAP_MSG_LCLS_NOTIFICATION:
+		return bssmap_rx_lcls_notif(conn, msg, &tp);
 	default:
 		LOGPCONN(conn, LOGL_ERROR, "Unimplemented msg type: %s\n", gsm0808_bssmap_name(msg_type));
 		return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/12608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5f9cad1f70aee56d5bca8fe09a24ca417e7a63
Gerrit-Change-Number: 12608
Gerrit-PatchSet: 5
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190124/6beebb38/attachment.htm>