Change in osmo-sip-connector[master]: Support Emergency Calling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 23 12:07:51 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )

Change subject: Support Emergency Calling
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c@427
PS1, Line 427: 	if (data->emergency) {
> which part?  I thin the if (data->emergency) is correct. […]
Curious, why the goto necessary in a first place? We don't have to screen parameters in case of emergency? Which of the conditions below trigger call reject and why?



-- 
To view, visit https://gerrit.osmocom.org/12682
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1
Gerrit-Change-Number: 12682
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Jan 2019 12:07:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190123/b5583d8e/attachment.htm>


More information about the gerrit-log mailing list