This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/12486 ) Change subject: LCLS: use libosmocore function to add status ...................................................................... Patch Set 4: Code-Review-1 (1 comment) Looks good, except for the indentation. https://gerrit.osmocom.org/#/c/12486/4/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/#/c/12486/4/src/osmo-bsc/assignment_fsm.c@181 PS4, Line 181: addr_local_p, sc_ptr, NULL, lcls_get_status(conn)); The indentation is not consistent, missing space before chosen_channel, and lchan->encr.alg_id. -- To view, visit https://gerrit.osmocom.org/12486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6916928391667cd9c345becf00e7c8561846c295 Gerrit-Change-Number: 12486 Gerrit-PatchSet: 4 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Tue, 22 Jan 2019 10:13:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190122/26be3695/attachment.htm>