Change in osmo-hlr[master]: VTY: integrate IMEI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Jan 21 15:49:47 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/12527 )

Change subject: VTY: integrate IMEI
......................................................................


Patch Set 8:

> generally I wonder whether we should just always drop that luhn check digit and only handle 14 digit IMEIs. Would that simplify anything?

I would rather keep it, it seems to be an useful feature to me and it is already implemented and working. I'll create a new patch that addresses the points you mentioned, thanks for the review.


-- 
To view, visit https://gerrit.osmocom.org/12527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1af7b573ca2a1cb22497052665012d9c1acf3b30
Gerrit-Change-Number: 12527
Gerrit-PatchSet: 8
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Jan 2019 15:49:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190121/958c92a3/attachment.htm>


More information about the gerrit-log mailing list