This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12624 ) Change subject: bsc_vty: add features to disable specific lchans via vty ...................................................................... Patch Set 2: (1 comment) I'm genrally worried when we introduce patches like this. They are very likely to confuse the regular operator/user and have possibly dangerous effects in production setups. At the very least, they should be added as HIDDEN vty commands, so they don't end up being documented and don't show up in vty autocompletion. Alternatively, one could have e.g. an environment variable that's only set during testing, which would be the precondition to registering related VTY commands. Specifically regarding this patch: Why introduce a new "disabled" member? Why not handle the disabled state as a state in the lchan FSM? https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/12624/2/src/osmo-bsc/bsc_vty.c@4796 PS2, Line 4796: DEFUN if we merge this at all, this should be a hidden command that is now displayed to the normal user. -- To view, visit https://gerrit.osmocom.org/12624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397e68e26d6a1727890353fa34f4897b54795866 Gerrit-Change-Number: 12624 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 18 Jan 2019 11:01:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190118/ea11b567/attachment.htm>