Change in osmo-hlr[master]: VTY: integrate IMEI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 16 15:44:57 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12527 )

Change subject: VTY: integrate IMEI
......................................................................


Patch Set 6:

(3 comments)

https://gerrit.osmocom.org/#/c/12527/6/src/hlr_vty_subscr.c
File src/hlr_vty_subscr.c:

https://gerrit.osmocom.org/#/c/12527/6/src/hlr_vty_subscr.c@146
PS6, Line 146: 		/* IMEI passwed with checksum digit: verify and remove */
typo


https://gerrit.osmocom.org/#/c/12527/6/src/hlr_vty_subscr.c@150
PS6, Line 150: 			imei_buf[14] = '\0';
Maybe use osmo_strlcpy() in here?


https://gerrit.osmocom.org/#/c/12527/6/src/hlr_vty_subscr.c@546
PS6, Line 546: 			imei_buf[14] = '\0';
Here too.



-- 
To view, visit https://gerrit.osmocom.org/12527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1af7b573ca2a1cb22497052665012d9c1acf3b30
Gerrit-Change-Number: 12527
Gerrit-PatchSet: 6
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jan 2019 15:44:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190116/3bfaace1/attachment.htm>


More information about the gerrit-log mailing list