Change in osmo-msc[master]: VLR: use msgb_eq_data_print() for comparison

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 16 13:21:11 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12571 )

Change subject: VLR: use msgb_eq_data_print() for comparison
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG@9
PS1, Line 9: This simplifies tests refactoring by showing exact byte where mismatch
> logs a multiline string to the osmo logging -- that's technically not allowed.

First time I hear about this. Why multiline logging is not allowed? I'm pretty sure I've seen it in several places before.



-- 
To view, visit https://gerrit.osmocom.org/12571
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jan 2019 13:21:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190116/6c4c7f9b/attachment.htm>


More information about the gerrit-log mailing list