Change in osmo-msc[master]: Enable SMS-related log in VLR tests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Jan 16 13:02:07 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12577 )

Change subject: Enable SMS-related log in VLR tests
......................................................................


Patch Set 2:

> Change has been successfully rebased and submitted as
 > 4813152691df910f9dbdb05d9e418be106c2cd14 by Max

> Since the comments were about cosmetic changes
> (which could be addressed later on) [...]

Why not to address them before merging?
At least the commit description could be modified.

Was it a critical fix that required immediate merge? No.


-- 
To view, visit https://gerrit.osmocom.org/12577
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44ae817d9edb73d182ff33ff5a2fd942e224e344
Gerrit-Change-Number: 12577
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jan 2019 13:02:07 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190116/81beb477/attachment.htm>


More information about the gerrit-log mailing list