This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/12577 ) Change subject: Enable SMS-related log in VLR tests ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Since the comments were about cosmetic changes (which could be addressed later on) and this patch adds test coverage to significant part of the code I'd rather get this merged right away. https://gerrit.osmocom.org/#/c/12577/1/tests/msc_vlr/msc_vlr_tests.c File tests/msc_vlr/msc_vlr_tests.c: https://gerrit.osmocom.org/#/c/12577/1/tests/msc_vlr/msc_vlr_tests.c@463 PS1, Line 463: test_categories > I think it's a better place for tuning logging... I've tried to use it but got weird error. Could be that I'm missing smth obvious but the essential part is to get SMS-related code covered by tests. Whether we do this via function call or extra struct field is rather minor implementation detail. -- To view, visit https://gerrit.osmocom.org/12577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44ae817d9edb73d182ff33ff5a2fd942e224e344 Gerrit-Change-Number: 12577 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Wed, 16 Jan 2019 12:56:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190116/76e5b2de/attachment.htm>