Change in libosmocore[master]: Add function to combine nibbles into byte

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 16 12:45:59 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12573 )

Change subject: Add function to combine nibbles into byte
......................................................................


Patch Set 2: Code-Review-1

I think this is API bloat.
We do a lot of custom bit shifting and it's not something that needs API.
Everyone knows how to compose a byte from two nibbles.
We're not likely to replace all the nibbles-to-byte conversions with calls to this function.
If you start like this, where will it lead? osmo_bytes_to_int16_t()? osmo_3bit_plus_5bit_to_byte()?


-- 
To view, visit https://gerrit.osmocom.org/12573
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I380687c31a787c0a109819f7c3b2946eae52675e
Gerrit-Change-Number: 12573
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 16 Jan 2019 12:45:59 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190116/58149ff0/attachment.htm>


More information about the gerrit-log mailing list