Change in osmo-msc[master]: Use transaction-specific debug macro

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 16 12:40:54 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12579 )

Change subject: Use transaction-specific debug macro
......................................................................


Patch Set 1:

(1 comment)

Generally a good idea;

- would prefer a LOG_TRANS(trans, LOGL_*, ...) that provides logging context for all log levels; and then replace all trans related logging with that.

- Meta: generates merge conflicts with my inter-MSC efforts

https://gerrit.osmocom.org/#/c/12579/1/src/libmsc/gsm_09_11.c
File src/libmsc/gsm_09_11.c:

https://gerrit.osmocom.org/#/c/12579/1/src/libmsc/gsm_09_11.c@295
PS1, Line 295: 	DEBUGP(DMM, "Establishing network-originated session\n");
e.g. this could also use trans context



-- 
To view, visit https://gerrit.osmocom.org/12579
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ad7d2f53c123ad656e8f23432f770ab1d5937e
Gerrit-Change-Number: 12579
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jan 2019 12:40:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190116/afb371c4/attachment.htm>


More information about the gerrit-log mailing list