Change in libosmocore[master]: Change GSM48_PDISC_* to enum type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 16 12:02:46 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12572 )

Change subject: Change GSM48_PDISC_* to enum type
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12572/2/include/osmocom/gsm/protocol/gsm_04_08.h
File include/osmocom/gsm/protocol/gsm_04_08.h:

https://gerrit.osmocom.org/#/c/12572/2/include/osmocom/gsm/protocol/gsm_04_08.h@1355
PS2, Line 1355: enum osmo_pdisc {
I do think some sort of layer name should be in there, just osmo_pdisc is too general. Given the value names I guess Vadim's choice is fair enough.

But on a meta level let's first discuss your plans for osmo-msc.



-- 
To view, visit https://gerrit.osmocom.org/12572
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbe8786a776081d7643193f154e6270224399e6
Gerrit-Change-Number: 12572
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 16 Jan 2019 12:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190116/a2ff7cd7/attachment.htm>


More information about the gerrit-log mailing list