Change in osmocom-bb[master]: layer23/sap_interface.c: reimplement (BT)SAP interface

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Jan 14 19:00:00 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12441 )

Change subject: layer23/sap_interface.c: reimplement (BT)SAP interface
......................................................................


Patch Set 8:

(4 comments)

https://gerrit.osmocom.org/#/c/12441/8//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12441/8//COMMIT_MSG@12
PS8, Line 12: a Bluetooth link.
Do you have a link to that part of BT spec by any chance? If so, would be cool to add it here or in the header file.


https://gerrit.osmocom.org/#/c/12441/8//COMMIT_MSG@61
PS8, Line 61: only imitation is Server-initiated Release, that allows the
typo


https://gerrit.osmocom.org/#/c/12441/8//COMMIT_MSG@64
PS8, Line 64: implemented (yet), and leds to immediate release.
here too.


https://gerrit.osmocom.org/#/c/12441/8/src/host/layer23/src/common/sap_fsm.c
File src/host/layer23/src/common/sap_fsm.c:

https://gerrit.osmocom.org/#/c/12441/8/src/host/layer23/src/common/sap_fsm.c@186
PS8, Line 186: 		/* Sent ATR request (required by the specs) */
Do you recall particular section?



-- 
To view, visit https://gerrit.osmocom.org/12441
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77bb108615bb2c94c441568f195b04e0a5421643
Gerrit-Change-Number: 12441
Gerrit-PatchSet: 8
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Jan 2019 19:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190114/5f2269a6/attachment.htm>


More information about the gerrit-log mailing list