Change in osmo-hlr[master]: Add IMEI column to subscriber table

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Jan 14 14:45:21 UTC 2019


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/12525

to look at the new patch set (#2).

Change subject: Add IMEI column to subscriber table
......................................................................

Add IMEI column to subscriber table

Extend the database scheme, add imei to the hlr_subscriber struct and
create db_subscr_update_imei_by_id() and db_subscr_get_by_imei(). The
new functions are used in db_test.

This change requires a HLR DB schema update. Existing databases
won't be upgraded automatically. However, osmo-hlr will refuse
to operate with databases which are not upgraded.

SQLite can only insert new columns at the end of the table, so this
happens when upgrading the database. In new databases, the column is
placed after the IMEISV column (where it makes more sense in my
opinion). This should not have any effect, as we never rely on the
order of the columns in the tables.

A follow-up commit will make use of this column to save the IMEI as
received from the MSC/VLR with the Check-IMEI Procedure. It was
decided to use Check-IMEI instead of the recent Automatic Device
Detection Procedure (which would send the IMEISV) in OS#3733, because
with Check-IMEI we don't need to rely on very recent releases of the
specification.

Depends: Id2d2a3a93b033bafc74c62e15297034bf4aafe61 (libosmocore)
Related: OS#2541
Change-Id: If232c80bea35d5c6864b889ae92d477eeaa3f45d
---
M sql/hlr.sql
M src/db.c
M src/db.h
M src/db_hlr.c
M tests/db/db_test.c
M tests/db/db_test.err
6 files changed, 212 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/25/12525/2
-- 
To view, visit https://gerrit.osmocom.org/12525
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If232c80bea35d5c6864b889ae92d477eeaa3f45d
Gerrit-Change-Number: 12525
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190114/21f8d6ac/attachment.htm>


More information about the gerrit-log mailing list