Change in osmo-msc[master]: transaction: drop unused ti_flag

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Jan 14 10:19:37 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 )

Change subject: transaction: drop unused ti_flag
......................................................................


Patch Set 1:

(1 comment)

> Patch Set 1: Code-Review-2

Could you please clarify why it's better to keep ti_flag parameter? Would be nice to add comment regarding the intention behind this variable or how it might be used in future.

https://gerrit.osmocom.org/#/c/12519/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12519/1//COMMIT_MSG@10
PS1, Line 10: unused
> Actually, it's used, but '0'B is always passed.
That's what I meant by "unused" - the variable is there but it's value always the same.



-- 
To view, visit https://gerrit.osmocom.org/12519
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie11999900b1789652ee078d34636dcda1e137eb0
Gerrit-Change-Number: 12519
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 14 Jan 2019 10:19:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190114/b0547201/attachment.htm>


More information about the gerrit-log mailing list