Change in libosmocore[master]: LCLS: add allocator function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 11 17:20:42 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12491 )

Change subject: LCLS: add allocator function
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12491/1/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/12491/1/src/gsm/gsm0808_utils.c@587
PS1, Line 587: r->gcr = talloc_zero(r, struct osmo_gcr_parsed);
please remind me, why again was the gcr member not a static member of the struct osmo_lcls and has to be dynamically allocated?



-- 
To view, visit https://gerrit.osmocom.org/12491
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If67cf93ae3dd449e96156485fe1baaf013df3f77
Gerrit-Change-Number: 12491
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Jan 2019 17:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190111/d2c584c0/attachment.htm>


More information about the gerrit-log mailing list