Change in libosmocore[master]: gsm23003: add osmo_imei_str_valid()

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12524 )

Change subject: gsm23003: add osmo_imei_str_valid()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12524/1/src/gsm/gsm23003.c
File src/gsm/gsm23003.c:

https://gerrit.osmocom.org/#/c/12524/1/src/gsm/gsm23003.c@75
PS1, Line 75: the 15th check digit is not
            :  * intended for digital transmission.
Sure. From the mentioned spec:

> The IMEI (14 digits) is complemented by a Check  Digit (CD). The Check Digit is not part of the digits transmitted  when the IMEI is checked, as described below. The Check Digit is intended to avoid manual transmission errors, e.g. when customers register stolen MEs at the operator's customer care desk. The Check Digit is defined according to the Luhn formula, as defined in annex B

In OsmoMSC, we store the IMEI with 14 digits, and it will also get sent with 14 digits from the MSC to the HLR (https://gerrit.osmocom.org/#/c/osmo-msc/+/12478/). Then the HLR will save the 14 digit version in the HLR DB (OS#2541).



-- 
To view, visit https://gerrit.osmocom.org/12524
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d2a3a93b033bafc74c62e15297034bf4aafe61
Gerrit-Change-Number: 12524
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Jan 2019 13:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190111/daf65fa9/attachment.htm>