Change in osmo-msc[master]: err log: fully log MS supported A5 algos on mismatch

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Jan 10 14:20:06 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12404 )

Change subject: err log: fully log MS supported A5 algos on mismatch
......................................................................


Patch Set 10:

(2 comments)

https://gerrit.osmocom.org/#/c/12404/10/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/#/c/12404/10/src/libmsc/gsm_04_08.c@124
PS10, Line 124: char cm1[42];
You could avoid 'else' branches this way:

  char cm1[42] = "no-cm1";
  char cm2[42] = " no-cm2";
  char cm3[42] = " no-cm3";


https://gerrit.osmocom.org/#/c/12404/10/src/libmsc/gsm_04_08.c@152
PS10, Line 152: snprintf
Let's check the rc at least here, just to be sure that we aren't printing garbage...



-- 
To view, visit https://gerrit.osmocom.org/12404
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb18e0f0bb420de066e7eb8fc683f192ba2a7368
Gerrit-Change-Number: 12404
Gerrit-PatchSet: 10
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 14:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190110/5dd78134/attachment.htm>


More information about the gerrit-log mailing list