Change in osmo-msc[master]: refactor log ctx for vlr_subscr and ran_conn

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Jan 10 14:11:37 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12402 )

Change subject: refactor log ctx for vlr_subscr and ran_conn
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.osmocom.org/#/c/12402/9/tests/msc_vlr/msc_vlr_test_authen_reuse.err
File tests/msc_vlr/msc_vlr_test_authen_reuse.err:

https://gerrit.osmocom.org/#/c/12402/9/tests/msc_vlr/msc_vlr_test_authen_reuse.err@11
PS9, Line 11: :
I think it makes sense to separate the RAT type from the subscriber name in some different way, e.g. using ' ', '|' or '/'. Probably, printing it first would also be better, just to compare:

  DMM RAN_conn(GERAN-A-0:LU IMSI-901700000010650){RAN_CONN_S_NEW}: Updated ID
  DMM RAN_conn(GERAN-A-0:LU|IMSI-901700000010650){RAN_CONN_S_NEW}: Updated ID
  DMM RAN_conn(GERAN-A-0:LU/IMSI-901700000010650){RAN_CONN_S_NEW}: Updated ID



-- 
To view, visit https://gerrit.osmocom.org/12402
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834
Gerrit-Change-Number: 12402
Gerrit-PatchSet: 9
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jan 2019 14:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190110/4507a971/attachment.htm>


More information about the gerrit-log mailing list