Change in osmo-msc[master]: rx CM Service Req: reject double use sooner

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12471 )

Change subject: rx CM Service Req: reject double use sooner
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/12471/2/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/#/c/12471/2/src/libmsc/gsm_04_08.c@738
PS2, Line 738: LOG_RAN_CONN
This could be done either in the previous patch, or in a separate one.


https://gerrit.osmocom.org/#/c/12471/2/src/libmsc/gsm_04_08.c@739
PS2, Line 739:      
Any reason of mixing tabs with spaces if this is not aligned anyway? Personally, I would prefer to see a line break with a single tab here:

  LOG_RAN_CONN(conn, LOGL_ERROR, "Cannot accept CM Service Request, "
    "conn already busy establishing authenticity\n");



-- 
To view, visit https://gerrit.osmocom.org/12471
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39209ee6662694aa054a2fc0d21eae76fb33e2f1
Gerrit-Change-Number: 12471
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 12:16:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190110/0fe9f30e/attachment.htm>