This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12483 ) Change subject: LCLS: add status parameter to Assignment Completed message ...................................................................... Patch Set 2: Code-Review-1 (3 comments) looks good except for minor tweaks... https://gerrit.osmocom.org/#/c/12483/2/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/12483/2/src/gsm/gsm0808.c@522 PS2, Line 522: /*! Create BSSMAP Assignment Completed message as per 3GPP TS 48.008 §3.2.1.2 (end with dot) https://gerrit.osmocom.org/#/c/12483/2/src/gsm/gsm0808.c@537 PS2, Line 537: enum gsm0808_lcls_status lcls_bss_status) looks like wrong indent on gerrit https://gerrit.osmocom.org/#/c/12483/2/src/gsm/gsm0808.c@577 PS2, Line 577: if (lcls_bss_status < GSM0808_LCLS_STS_NA) prefer '!= GSM0808_LCLS_STS_NA' to not make assumptions on enum value ordering. -- To view, visit https://gerrit.osmocom.org/12483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I547c6b8707123aa8c1ef636db88908df112d90a4 Gerrit-Change-Number: 12483 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Wed, 09 Jan 2019 16:27:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190109/c6a07ca0/attachment.htm>