Change in libosmocore[master]: LCLS: don't encode incorrect values

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 9 16:22:54 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12375 )

Change subject: LCLS: don't encode incorrect values
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12375/3/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/#/c/12375/3/src/gsm/gsm0808.c@346
PS3, Line 346: 		return NULL;
Have you seen a situation where these values were wrong / do they come from rx'ing packets?
If these are directly called with enum constants from our code, I wouldn't bother to check them.

If keeping the check:
- enums can also have negative values.
- what about the enum values in-between ST_LOCALLY_SWITCHED and _NA.



-- 
To view, visit https://gerrit.osmocom.org/12375
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59
Gerrit-Change-Number: 12375
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 09 Jan 2019 16:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190109/dbbeb7c5/attachment.htm>


More information about the gerrit-log mailing list