Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 9 14:46:54 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12478 )

Change subject: VLR: send CHECK-IMEI to EIR/HLR
......................................................................


Patch Set 6: Code-Review-1

(6 comments)

very nice so far.

Also add an msc_vlr_test that NACKs and one that ERRs the IMSI? Or are you doing that in TTCN3 already?

maybe drop the FIXME from vlr_lu_fsm.c:506?

https://gerrit.osmocom.org/#/c/12478/6/src/libvlr/vlr.c
File src/libvlr/vlr.c:

https://gerrit.osmocom.org/#/c/12478/6/src/libvlr/vlr.c@1017
PS6, Line 1017: 	osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_LU_COMPL_FAILURE, (void *)&gsup->cause);
state LU_COMPL_VLR_S_WAIT_IMEI in vlr_lu_fsm.c doesn't allow event VLR_ULA_E_LU_COMPL_FAILURE?

(a cast to void* is never needed)


https://gerrit.osmocom.org/#/c/12478/6/src/libvlr/vlr.c@1033
PS6, Line 1033: 		osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_HLR_IMEI_NACK, (void *)&gsup->cause);
what's the difference between the error above and this NACK?

These events do not evaluate any data argument, do they?


https://gerrit.osmocom.org/#/c/12478/6/tests/msc_vlr/msc_vlr_test_gsm_authen.c
File tests/msc_vlr/msc_vlr_test_gsm_authen.c:

https://gerrit.osmocom.org/#/c/12478/6/tests/msc_vlr/msc_vlr_test_gsm_authen.c@579
PS6, Line 579: 
insert here another EXPECT_ACCEPTED(false) and thwart_rx_non_initial_requests().


https://gerrit.osmocom.org/#/c/12478/6/tests/msc_vlr/msc_vlr_test_gsm_authen.c@686
PS6, Line 686: 
and here


https://gerrit.osmocom.org/#/c/12478/6/tests/msc_vlr/msc_vlr_test_gsm_ciph.c
File tests/msc_vlr/msc_vlr_test_gsm_ciph.c:

https://gerrit.osmocom.org/#/c/12478/6/tests/msc_vlr/msc_vlr_test_gsm_ciph.c@559
PS6, Line 559: 
and here


https://gerrit.osmocom.org/#/c/12478/6/tests/msc_vlr/msc_vlr_test_gsm_ciph.c@768
PS6, Line 768: 
and here



-- 
To view, visit https://gerrit.osmocom.org/12478
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife868ed71c36cdd02638072abebf61fc949080a7
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 6
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 14:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190109/2f9bb63a/attachment.htm>


More information about the gerrit-log mailing list