Change in libosmocore[master]: LCLS: don't encode incorrect values

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Jan 8 12:51:15 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12375 )

Change subject: LCLS: don't encode incorrect values
......................................................................


Patch Set 2:

(1 comment)

Addressed in latest revision.

https://gerrit.osmocom.org/#/c/12375/1/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/#/c/12375/1/src/gsm/gsm0808.c@340
PS1, Line 340: 	if (status >= GSM0808_LCLS_STS_NA)
> I'm not sure this is worth it. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/12375
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59
Gerrit-Change-Number: 12375
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 08 Jan 2019 12:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190108/1f2586ff/attachment.htm>


More information about the gerrit-log mailing list