Change in osmo-msc[master]: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11920 )

Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP
......................................................................


Patch Set 11:

(7 comments)

https://gerrit.osmocom.org/#/c/11920/11/src/libmsc/gsm_04_11.c
File src/libmsc/gsm_04_11.c:

https://gerrit.osmocom.org/#/c/11920/11/src/libmsc/gsm_04_11.c@162
PS11, Line 162: 		if (sms != NULL) { /* gsm411_send_rp_data() doesn't set trans->sms.sms */
> put the "doesn't set" above the 'if', and the 'Notify... […]
Done


https://gerrit.osmocom.org/#/c/11920/11/src/libmsc/gsm_04_11.c@1147
PS11, Line 1147: 
> hmm, I sort of expected a TLV structure, but there are no Ts... too late for that I guess.
Please see GSM TS 04.11, Table 7.4/3GPP TS 04.11: RP-DATA message content.


https://gerrit.osmocom.org/#/c/11920/11/src/libmsc/gsm_04_11.c@1148
PS11, Line 1148: 	/* Encode RP-DA length */
> OA?
Sure, thanks!


https://gerrit.osmocom.org/#/c/11920/11/src/libmsc/gsm_04_11.c@1154
PS11, Line 1154: 	memcpy(ptr, sm_rp_oa, sm_rp_oa_len);
> Rather use msgb_lv_put()?
Done


https://gerrit.osmocom.org/#/c/11920/11/src/libmsc/gsm_04_11.c@1158
PS11, Line 1158: 	ptr[0] = 0x00;
> msgb_put_u8()? msgb_v_put()?
Done


https://gerrit.osmocom.org/#/c/11920/11/src/libmsc/gsm_04_11.c@1166
PS11, Line 1166: 	memcpy(ptr, sm_rp_ud, sm_rp_ud_len);
> msgb_lv_put()?
Done


https://gerrit.osmocom.org/#/c/11920/11/src/libmsc/gsm_04_11.c@1170
PS11, Line 1170: 	return gsm411_rp_sendmsg(&trans->sms.smr_inst, msg,
> API wise it would be better to have separate functions that encode and send. […]
I think we can split it later. At the moment I don't see
any use cases for a separate encoding function...



-- 
To view, visit https://gerrit.osmocom.org/11920
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57357982ca0e51f6722c24a4aa1d0fb3e6caef88
Gerrit-Change-Number: 11920
Gerrit-PatchSet: 11
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Sat, 05 Jan 2019 13:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190105/6d830f3c/attachment.htm>