Change in osmo-msc[master]: mncc socket: add field ran

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Thu Jan 3 22:43:04 UTC 2019


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/12457 )

Change subject: mncc socket: add field ran
......................................................................


Patch Set 2:

> What I'm missing here is some kind of description on why it is
 > added and for what it is intended to be used.  Normally, a MNCC
 > peer should not care about what kind of RAT is used.  Also, the RAT
 > can change at any time, even multiple times during a call.  So in
 > general, I would avoid falling into the same trap as we did when
 > "lchan" information was added to MNCC.  Call Control should not
 > care about this and should live on a much higher layer.  So please
 > let's state explicitly why it is added and what it's used for
 > before taking any decisions on merging this.  Also, any change to
 > the layout of MNCC should bump the related version, shouldn't it?

The idea is to push the information back via SIP to the PBX (there is already a Sipheader). We could do special extension e.g. read what RAT you're using. Thomas from the PoC @ 35c3 asked for this header. I don't know for what we would like to use it atm.


-- 
To view, visit https://gerrit.osmocom.org/12457
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f28dbca1b515f9eaa6a8708a7ccfa1eb6f6b6cc
Gerrit-Change-Number: 12457
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Thu, 03 Jan 2019 22:43:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190103/d832c9db/attachment.htm>


More information about the gerrit-log mailing list