Change in osmo-msc[master]: refactor ran_conn_get_conn_id()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Jan 3 12:57:29 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12453 )

Change subject: refactor ran_conn_get_conn_id()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12453/1/src/libmsc/ran_conn.c
File src/libmsc/ran_conn.c:

https://gerrit.osmocom.org/#/c/12453/1/src/libmsc/ran_conn.c@512
PS1, Line 512: Truncation should never happen
Why should we care about it then?

I would rather check if rc > 0, because:

  "If an output error is encountered, a negative value is returned."



-- 
To view, visit https://gerrit.osmocom.org/12453
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c022a995c11478201e0faeaf748e74dc38e05f
Gerrit-Change-Number: 12453
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 03 Jan 2019 12:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190103/bbcdd069/attachment.htm>


More information about the gerrit-log mailing list