Change in osmo-msc[master]: Don't deliver alert notifications to ESME not yet bound.

[Keith Whyte]

Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12599 )

Change subject: Don't deliver alert notifications to ESME not yet bound. 
......................................................................

Don't deliver alert notifications to ESME not yet bound. 

We create a new ESME in smsc->esme_list on establishment
of a TCP connection, yet we do not know the system id 
or anything else, until the ESME identifies and authenticates.

So do not send alert notifications until
we know the bind status (and system_id)

Change-Id: Iec92d4c145ca050c2e212139572eeaae581b99df
---
M src/libmsc/smpp_openbsc.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/libmsc/smpp_openbsc.c b/src/libmsc/smpp_openbsc.c
index fb9b0f8..9156445 100644
--- a/src/libmsc/smpp_openbsc.c
+++ b/src/libmsc/smpp_openbsc.c
@@ -284,6 +284,11 @@
 		/* we currently send an alert notification to each ESME that is
 		 * connected, and do not require a (non-existant) delivery
 		 * pending flag to be set before. */
+		if (!esme->bind_flags) {
+			LOGP(DSMPP, LOGL_DEBUG,
+				"ESME is not (yet) bound, skipping alert\n");
+			continue;
+		}
 		if (!esme->acl->alert_notifications) {
 			LOGP(DSMPP, LOGL_DEBUG,
 				"[%s] is not set to receive Alert Notifications\n",

-- 
To view, visit https://gerrit.osmocom.org/12599
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec92d4c145ca050c2e212139572eeaae581b99df
Gerrit-Change-Number: 12599
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190228/02c7773b/attachment.htm>