Change in libosmo-netif[master]: AMR: add define constants for AMR payload length

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 28 10:41:40 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13078 )

Change subject: AMR: add define constants for AMR payload length
......................................................................


Patch Set 1:

(1 comment)

I would also argue the fix and the "cosmetic" change should be separate patches. Thanks!

https://gerrit.osmocom.org/#/c/13078/1/include/osmocom/netif/amr.h
File include/osmocom/netif/amr.h:

https://gerrit.osmocom.org/#/c/13078/1/include/osmocom/netif/amr.h@86
PS1, Line 86: /* AMR voice frame length (in bytes, rounded),
might be good to qualify what kind of length.  Length of the AMR codec data after TOC? Length of the RTP payload after RTP header? ...



-- 
To view, visit https://gerrit.osmocom.org/13078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b5da920d58015b875d6dcf17aacdc04b58955e
Gerrit-Change-Number: 13078
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 28 Feb 2019 10:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190228/b28f3253/attachment.htm>


More information about the gerrit-log mailing list