Change in osmo-pcu[master]: MCS: move Coding Scheme enum to C header

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 26 22:41:43 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13064 )

Change subject: MCS: move Coding Scheme enum to C header
......................................................................


Patch Set 1:

the code you're touching is undoubtedly C++ code.  I'm not sure if it's an improvement to turn [more] parts of it into C.  Also, I don't see from your changes or from the commitlog *why* this simplifies testing.  It's not clear that C++ can be tested less than C ?1?


-- 
To view, visit https://gerrit.osmocom.org/13064
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I993b49d9a82b8c7ad677d52d11003794aeabe117
Gerrit-Change-Number: 13064
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:41:43 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190226/e8587b83/attachment.htm>


More information about the gerrit-log mailing list