This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13023 ) Change subject: NS: Factor out gprs_nsvc_start_test() and use it ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13023/1/src/gb/gprs_ns.c File src/gb/gprs_ns.c: https://gerrit.osmocom.org/#/c/13023/1/src/gb/gprs_ns.c@1952 PS1, Line 1952: gprs_ns_tx_alive(nsvc); > We are losing posible error condition here. […] I'm not entirely sure that this error propagation actually makse sense in that case. Like, at least historically, in many cases in osmocom. We used to have situations where the socked would be closed because some function at some point returned -1 and everyon passed it up all the way onto the select call-back. Right here the point is that an ALIVE message is transmitted every time the timer expires. So if the first transmission should fail, there will be many more re-transmissions due to the timer we're starting in the next line. All this is over UDP anyway, so packet loss is something both sides have to deal with somehow anyway. -- To view, visit https://gerrit.osmocom.org/13023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d303117f77fabb74bbb91887b9914a81c2a084a Gerrit-Change-Number: 13023 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 26 Feb 2019 09:22:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190226/f399699f/attachment.htm>