Change in libosmocore[master]: gprs_ns: Add code for SNS-SIZE and SNS-CONFIG encoding

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Feb 25 13:01:04 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13013 )

Change subject: gprs_ns: Add code for SNS-SIZE and SNS-CONFIG encoding
......................................................................


Patch Set 3:

(2 comments)

Spec reference confusion should be clarified.

https://gerrit.osmocom.org/#/c/13013/3/src/gb/gprs_ns.c
File src/gb/gprs_ns.c:

https://gerrit.osmocom.org/#/c/13013/3/src/gb/gprs_ns.c@3
PS3, Line 3:  * 3GPP TS 08.16 version 8.0.1 Release 1999 / ETSI TS 101 299 V8.0.1 (2002-05). */
We should add TS 48.016 spec reference as well.


https://gerrit.osmocom.org/#/c/13013/3/src/gb/gprs_ns.c@760
PS3, Line 760: /*! Encode + Transmit a SNS-ACK as per Section 9.3.1.
There's no such section in 08.16 which is referred to in the header. It's in 48.016.



-- 
To view, visit https://gerrit.osmocom.org/13013
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c47e1c3c10deb89a7470ee2c03adfc174accc93
Gerrit-Change-Number: 13013
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Feb 2019 13:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190225/bee12f63/attachment.htm>


More information about the gerrit-log mailing list