Change in osmo-ttcn3-hacks[master]: PCU: Add test for SNS Change Weight procedure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sat Feb 23 23:25:49 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13027 )

Change subject: PCU: Add test for SNS Change Weight procedure
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13027/1/pcu/PCU_Tests_RAW_SNS.ttcn
File pcu/PCU_Tests_RAW_SNS.ttcn:

https://gerrit.osmocom.org/#/c/13027/1/pcu/PCU_Tests_RAW_SNS.ttcn@99
PS1, Line 99: 	NSCP[idx].send(t_NS_Send(g_ns_conn_id[idx], ts_SNS_CHG_WEIGHT(g_nsconfig[idx].nsei, 25, v4)));
Is g_nsconfig[idx].nsei correct? Shouldn't it be g_nsconfig[idx_chg].nsei? Or idx is the old one and idx_chg is the new one?

Same in line below.



-- 
To view, visit https://gerrit.osmocom.org/13027
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia63865139f63969ccde010b01ddb8fb073209f3a
Gerrit-Change-Number: 13027
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Feb 2019 23:25:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190223/4bbbda04/attachment.htm>


More information about the gerrit-log mailing list