This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13023 ) Change subject: NS: Factor out gprs_nsvc_start_test() and use it ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13023/1/src/gb/gprs_ns.c File src/gb/gprs_ns.c: https://gerrit.osmocom.org/#/c/13023/1/src/gb/gprs_ns.c@1952 PS1, Line 1952: gprs_ns_tx_alive(nsvc); We are losing posible error condition here. Would make sense to return negative on error o 0 on success, and use that return code in gprs_ns_rx_reset_ack. -- To view, visit https://gerrit.osmocom.org/13023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d303117f77fabb74bbb91887b9914a81c2a084a Gerrit-Change-Number: 13023 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 23 Feb 2019 23:06:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190223/f07abb46/attachment.htm>