Change in osmo-msc[master]: libmsc/sgs_vty.c: fix dead array comparation against null

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Feb 23 09:54:23 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13017 )

Change subject: libmsc/sgs_vty.c: fix dead array comparation against null
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13017/1/src/libmsc/sgs_vty.c
File src/libmsc/sgs_vty.c:

https://gerrit.osmocom.org/#/c/13017/1/src/libmsc/sgs_vty.c@163
PS1, Line 163: 	if (strcmp(sgs->cfg.local_addr, DEFAULT_SGS_SERVER_IP))
I think it makes more sense to drop these conditions and print default values too, as we do in the 'hlr' section. The VTY tests expect default values to be printed, excluding port.



-- 
To view, visit https://gerrit.osmocom.org/13017
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If045e42fca0315b0777eb86c44bf934ce58b340b
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 23 Feb 2019 09:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190223/32996d70/attachment.htm>


More information about the gerrit-log mailing list