Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12979 )

Change subject: Add option to GSM HR frames to RFC5593 representation
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/12979/3/src/libosmo-mgcp/mgcp_network.c
File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/#/c/12979/3/src/libosmo-mgcp/mgcp_network.c@676
PS3, Line 676: 	} else if (*len == GSM_HR_BYTES + sizeof(struct rtp_hdr) + 1) {
According to https://tools.ietf.org/html/rfc5993#section-5.2 there can be multiple speech/SID frames in one UDP packet which would then cause multiple TOC bytes to be present as well.

Since we don't see this behaviour I don't think we should implement it, but rather ensure that toc & 0x01 == 0 in this case and log an error if the length is different than the two expected values.

-----

 0 1 2 3 4 5 6 7
+-+-+-+-+-+-+-+-+
|F| FT  |R R R R|
+-+-+-+-+-+-+-+-+

F: Follow flag; 1 denotes that more ToC elements follow; 0 denotes the last ToC element.


https://gerrit.osmocom.org/#/c/12979/3/src/libosmo-mgcp/mgcp_network.c@680
PS3, Line 680: 	}
else {
LOGP(DRTP, LOGL_ERROR, "Can't figure out how to convert RTP packet\n");
}



-- 
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Fri, 22 Feb 2019 13:36:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190222/d18cd225/attachment.htm>