Change in osmo-bts[master]: oc2g: vty: Compilation error fixes due to commented code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Feb 21 13:26:50 UTC 2019


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12973 )

Change subject: oc2g: vty: Compilation error fixes due to commented code
......................................................................

oc2g: vty: Compilation error fixes due to commented code

Change-Id: Id2b16b9acd15d0c80085fac0fdc2a57173ebb0a0
---
M src/osmo-bts-oc2g/oc2gbts_vty.c
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-oc2g/oc2gbts_vty.c b/src/osmo-bts-oc2g/oc2gbts_vty.c
index 099698f..9bb4579 100644
--- a/src/osmo-bts-oc2g/oc2gbts_vty.c
+++ b/src/osmo-bts-oc2g/oc2gbts_vty.c
@@ -77,11 +77,13 @@
 	{ 0, NULL }
 };
 
+/*
 static const struct value_string oc2g_led_mode_strs[] = {
 	{ OC2G_LED_CONTROL_BTS, "bts" },
 	{ OC2G_LED_CONTROL_EXT, "external" },
 	{ 0, NULL }
 };
+*/
 
 static const struct value_string oc2g_auto_adj_pwr_strs[] = {
 	{ OC2G_TX_PWR_ADJ_NONE, "none" },
@@ -455,7 +457,7 @@
 	struct gsm_lchan *lchan;
 	int trx_nr, ts_nr, lchan_nr;
 	uint8_t ho_cause;
-	uint8_t old_ho_cause;
+	/* uint8_t old_ho_cause; */
 
 	/* get BTS pointer */
 	bts = gsm_bts_num(net, 0);
@@ -519,6 +521,7 @@
 	/ * restore HO cause * /
 	lchan->meas_preproc.rec_ho_causes = old_ho_cause;
 	*/
+	(void)lchan; /* to use lchan and avoid compilation warning */
 
 	return CMD_SUCCESS;
 }
@@ -728,5 +731,5 @@
 	rc |= ctrl_cmd_install(CTRL_NODE_ROOT, &cmd_oc2g_oml_ceased);
 	*/
 
-	return 0;
+	return rc;
 }

-- 
To view, visit https://gerrit.osmocom.org/12973
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2b16b9acd15d0c80085fac0fdc2a57173ebb0a0
Gerrit-Change-Number: 12973
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190221/16b978e0/attachment.htm>


More information about the gerrit-log mailing list