Change in osmo-mgw[master]: Add option to GSM HR frames to RFC5593 representation

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12979 )

Change subject: Add option to GSM HR frames to RFC5593 representation
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/12979/1/src/libosmo-mgcp/mgcp_network.c
File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/#/c/12979/1/src/libosmo-mgcp/mgcp_network.c@655
PS1, Line 655: /* This has been ported from openbsc.git, branch sylvain/32c3_codec,
> Is this comment really needed here? Better put it in commit description.
I don't mind either way.


https://gerrit.osmocom.org/#/c/12979/1/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/#/c/12979/1/src/libosmo-mgcp/mgcp_vty.c@107
PS1, Line 107: 		vty_out(vty, "  %srtp-patch rfc5993hr%s",
             : 			g_cfg->trunk.rfc5993_hr_convert ? "" : "no ",
             : 			VTY_NEWLINE);
I think it's important to somehow explain that this is not patching the RFC5993 format, but it is in fact patching (better: converting) the older ETSI TS [FIXME] format to become RFC5993.  This should be implied by naming of the VTY option and variable.



-- 
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 20 Feb 2019 20:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190220/bb61f9cf/attachment.htm>