Change in osmo-bts[master]: oc2g: Fix compilation error (comment mark inside comment)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Feb 20 17:13:07 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12962 )

Change subject: oc2g: Fix compilation error (comment mark inside comment)
......................................................................


Patch Set 2:

> A better approach would be to use:
 > 
 > #if 0
 > ...
 > #endif
 > 
 > instead of abusing comments.

Sure makes sense, but I don't plan to invest time on this code since anyway will be cleaned/improved later. For now I'm just clearing some obvious compile time warnings/errors to better see how other more annoying warnings need to be fixed and avoid adding new warnings later on with new development.


-- 
To view, visit https://gerrit.osmocom.org/12962
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib27b31825744ea397b5b4eb258da78f5f834895c
Gerrit-Change-Number: 12962
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 17:13:07 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190220/6d3b0534/attachment.htm>


More information about the gerrit-log mailing list