This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12969 ) Change subject: gprs_ns: Add missing NSVCI IE to NS-BLOCK-ACK message ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12969/1/src/gb/gprs_ns.c File src/gb/gprs_ns.c: https://gerrit.osmocom.org/#/c/12969/1/src/gb/gprs_ns.c@560 PS1, Line 560: log_set_context(LOG_CTX_GB_NSVC, nsvc); > You most probably want to remove the context once you get out of the function, to avoid having non-r […] the style of this function follows the style of all the other functions in this file. You raise an interesting question, but I don't immediately see any code path where within a single "read from select" callback from libosmocore we would be processing messages for multiple NSVCs. Each incoming message relates to zero to one NSVC, and any messages transmitted as a result are also related to that NS-VC. -- To view, visit https://gerrit.osmocom.org/12969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7205e99d57f1e42d941f1be2460d8c9f46aadfe Gerrit-Change-Number: 12969 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 20 Feb 2019 07:30:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190220/954b538b/attachment.htm>