Change in libosmocore[master]: rsl: Support PDCH in rsl_chan_nr_str

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 19 12:27:59 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12942 )

Change subject: rsl: Support PDCH in rsl_chan_nr_str
......................................................................

rsl: Support PDCH in rsl_chan_nr_str

During log review lack of support  for PDCH was spotted:

scheduler.c:593 Configuring multiframe with PDCH trx=0 ts=4
rsl.c:1159 (bts=0,trx=0,ts=4,ss=0): chan_nr=UNKNOWN on TS4 type=0x00 mode=SIGNALLING
rsl.c:741 (bts=0,trx=0,ts=4,pchan=TCH/F_TCH/H_PDCH as PDCH) (ss=0) PDTCH Tx CHAN ACT ACK

Wireshark shows:
1100 0... = C-bits: PDCH (24)
.... .100 = Time slot number (TN): 4

Change-Id: If6ed96c9eb0431eb24e2135634def61e0ea506ea
---
M src/gsm/rsl.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c
index abda932..e610ebf 100644
--- a/src/gsm/rsl.c
+++ b/src/gsm/rsl.c
@@ -236,6 +236,8 @@
 		sprintf(str, "RACH on TS%d", ts);
 	else if (cbits == 0x12)
 		sprintf(str, "PCH/AGCH on TS%d", ts);
+	else if (cbits == 0x18)
+		sprintf(str, "PDCH on TS%d", ts);
 	else
 		sprintf(str, "UNKNOWN on TS%d", ts);
 

-- 
To view, visit https://gerrit.osmocom.org/12942
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If6ed96c9eb0431eb24e2135634def61e0ea506ea
Gerrit-Change-Number: 12942
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190219/7d606314/attachment.htm>


More information about the gerrit-log mailing list