Change in osmo-pcu[master]: Add encoding tests for Immediate Assignment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Feb 19 09:09:14 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12947 )

Change subject: Add encoding tests for Immediate Assignment
......................................................................


Patch Set 2:

(1 comment)

The rest should be addressed in the latest revision.

https://gerrit.osmocom.org/#/c/12947/1/tests/types/TypesTest.cpp
File tests/types/TypesTest.cpp:

https://gerrit.osmocom.org/#/c/12947/1/tests/types/TypesTest.cpp@458
PS1, Line 458: void test_immediate_assign_dl()
> the_bts? lol why not "bts"?
That's convention throughout the rest of the code - grep the sources.



-- 
To view, visit https://gerrit.osmocom.org/12947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63f4654b23c7c4f063f6b3254d77157fac798586
Gerrit-Change-Number: 12947
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Feb 2019 09:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190219/d286ac51/attachment.htm>


More information about the gerrit-log mailing list