Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

[tnt]

tnt has posted comments on this change. ( https://gerrit.osmocom.org/12625 )

Change subject: assignment_fsm: fix channel allocator preferences
......................................................................


Patch Set 11:

(1 comment)

* See comment about the unsupported value, any reason for this ?

* The preference of codec expressed by the MSC in the assignement message is AFAICT completely ignored in favor of the local preference data (i.e. it scans msc->audio_support[i] in order and check for a match at any location in the assignement message and doesn't take into account the order inside th e message). I think the BSC is free to ignore that order, just wanted to make sure it was a conscious decision.

Rest looks fine.

https://gerrit.osmocom.org/#/c/12625/11/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/#/c/12625/11/src/osmo-bsc/osmo_bsc_bssap.c@635
PS11, Line 635: 	switch (ct->ch_rate_type) {
GSM0808_SPEECH_PERM and GSM0808_SPEECH_PERM_NO_CHANGE  are not handled ?
AFAICT, those are perfectly legal values, just indicating there is not preference for the channel type and that all preferences are expressed via the codec list.



-- 
To view, visit https://gerrit.osmocom.org/12625
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51
Gerrit-Change-Number: 12625
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Mon, 18 Feb 2019 14:30:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190218/984a35d6/attachment.htm>