Change in libosmocore[master]: gsm0808: comment about difference of gsm0808_create_clear_command()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 18 12:49:16 UTC 2019


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/12932


Change subject: gsm0808: comment about difference of gsm0808_create_clear_command()
......................................................................

gsm0808: comment about difference of gsm0808_create_clear_command()

This single function has a quite different behavior than the other
gsm0808_ functions in terms of how the resulting msgb l2h and l3h
pointers are set.  Let's document that to avoid more confusion.

Change-Id: I0367760a588fc968c5a2dea46001ef1ee7965c8c
---
M src/gsm/gsm0808.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/12932/1

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 86b6c05..5be227e 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -178,7 +178,10 @@
 	return msg;
 }
 
-/*! Create BSSMAP Clear Command message
+/*! Create BSSMAP Clear Command message with BSSAP header in l2h and BSSMAP in l3h.
+ *  This is quite different from most (all?) other gsm0808_create_* which have l3h
+ *  point to the BSSAP header.  However, we have to keep this for backwards compatibility.
+ *  Use gsm0808_create_clear_command2() for a 'modern' implementation.
  *  \param[in] cause TS 08.08 cause value
  *  \returns callee-allocated msgb with BSSMAP Clear Command message */
 struct msgb *gsm0808_create_clear_command(uint8_t cause)

-- 
To view, visit https://gerrit.osmocom.org/12932
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0367760a588fc968c5a2dea46001ef1ee7965c8c
Gerrit-Change-Number: 12932
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190218/d04223fa/attachment.htm>


More information about the gerrit-log mailing list