Change in osmocom-bb[master]: firmware/board/pirelli_dpl10: fix ASIC_CONF_REG setting

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 14 21:45:30 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12882 )

Change subject: firmware/board/pirelli_dpl10: fix ASIC_CONF_REG setting
......................................................................

firmware/board/pirelli_dpl10: fix ASIC_CONF_REG setting

Set LPG and PWL pin mux like Pirelli's firmware does.

Change-Id: I099e13800b7821a8fb274c5264c9823153afe564
---
M src/target/firmware/board/pirelli_dpl10/init.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, but someone else must approve
  Max: Looks good to me, approved



diff --git a/src/target/firmware/board/pirelli_dpl10/init.c b/src/target/firmware/board/pirelli_dpl10/init.c
index 4c74a6d..da23308 100644
--- a/src/target/firmware/board/pirelli_dpl10/init.c
+++ b/src/target/firmware/board/pirelli_dpl10/init.c
@@ -60,8 +60,8 @@
 	uint16_t reg;
 
 	reg = readw(ASIC_CONF_REG);
-	/* Set function pins to I2C Mode */
-	reg |= ((1 << 12) | (1 << 7));		/* SCL / SDA */
+	/* Set LPG and PWL pin mux like Pirelli's fw does */
+	reg |= (1 << 6) | (1 << 4);
 	/* TWL3025: Set SPI+RIF RX clock to rising edge */
 	reg |= (1 << 13) | (1 << 14);
 	reg &= ~(1 << 1);

-- 
To view, visit https://gerrit.osmocom.org/12882
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I099e13800b7821a8fb274c5264c9823153afe564
Gerrit-Change-Number: 12882
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: steve-m <steve at steve-m.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190214/e4c2d99d/attachment.htm>


More information about the gerrit-log mailing list