This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/12901 ) Change subject: transaction: clarify magic 0xff transaction ID ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Anyway, just a food for thought, not an obstacle for merging this. https://gerrit.osmocom.org/#/c/12901/2/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/#/c/12901/2/src/libmsc/gsm_04_11.c@1044 PS2, Line 1044: /* According to 8.2.3, MR is in the range 0 through 255 */ That kinda looks suspicious as well: it's not clear from the comment whether 255 is included in the range but it's never reached by the cycle below. -- To view, visit https://gerrit.osmocom.org/12901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d3a6334f49989bedbb1430d26ffad8b61dfd873 Gerrit-Change-Number: 12901 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 14 Feb 2019 16:45:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190214/9dd922f0/attachment.htm>