Change in osmo-bsc[master]: OML: Fix encoded length value of OML GET ATTRIBUTES

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Feb 14 11:06:20 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/12890 )

Change subject: OML: Fix encoded length value of OML GET ATTRIBUTES
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12890/1/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/#/c/12890/1/src/osmo-bsc/abis_nm.c@1720
PS1, Line 1720: 	fill_om_fom_hdr(oh, 3+attr_len, NM_MT_GET_ATTR, obj_class,
> I guess those 3 bytes are the T and L16 parts of TL16V missing right? You could explain that in the  […]
That would be handy indeed: fill_om_fom_hdr() is sometimes called with 2+sizeof(), sometime with explicit number (2, 3, 6, even 0) so it's pretty confusing overall.



-- 
To view, visit https://gerrit.osmocom.org/12890
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56068de0bb14a99ec39be587e542e27cddb7d1df
Gerrit-Change-Number: 12890
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Feb 2019 11:06:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190214/f16fb4a4/attachment.htm>


More information about the gerrit-log mailing list