Change in osmocom-bb[master]: firmware/board: introduce new FCDEV3B (FreeCalypso) target

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Feb 14 09:24:06 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12888 )

Change subject: firmware/board: introduce new FCDEV3B (FreeCalypso) target
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/12888/3/src/target/firmware/board/fcdev3b/init.c
File src/target/firmware/board/fcdev3b/init.c:

https://gerrit.osmocom.org/#/c/12888/3/src/target/firmware/board/fcdev3b/init.c@49
PS3, Line 49: #include "../compal/keymap.h"
Most likely, we don't need this as the FCDEV3B has no keyboard.


https://gerrit.osmocom.org/#/c/12888/3/src/target/firmware/board/fcdev3b/init.c@141
PS3, Line 141: Initialize LCD driver (uses I2C) and backlight
Same here, the board has no LCD.


https://gerrit.osmocom.org/#/c/12888/3/src/target/firmware/board/fcdev3b/init.c@145
PS3, Line 145: /* Initialize keypad driver */
FCDEV3B has no keyboard.



-- 
To view, visit https://gerrit.osmocom.org/12888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09bd35a18d3ea094000050169a62fd82ba6eccfe
Gerrit-Change-Number: 12888
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 09:24:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190214/3bc29b5b/attachment.htm>


More information about the gerrit-log mailing list